OpenMapTiles implementation: Add missing attributes to transportation and places layer #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds following attributes according to the documentation: surface, mtb_scale, expressway, access, bicycle, foot, horse, toll, layer
Original OpenMapTiles joins ne_10m_populated_places and OSM places by their Wikidata ID (and names as fallback). We do not use NaturalEarth, therefore we rely on population and capital only to calculate the rank.
|
Thank you! One refinement you could use - and this is my fault for not documenting it - is that you can actually specify the minimum zoom level at which an attribute is written. You do this by supplying a third parameter to the Could I suggest a slight rewrite to use this? It should simplify the code because you won't need to have all the extra layers, you can just write it once but set the minzoom on each attribute. And I'll fix the documentation. :) |
Make use of the new way:Attribute(name, value, minzoom) function.
|
@systemed I rewrote the code. |
|
Excellent - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client complained about missing attributes. I compared the implementation with the schema and fixed the differences.
I found differences w.r.t. to the
poislayer as well but I will offer those in a separate pull request.